Skip to content

c-searchで fixie アドレスを使用する #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

rakuda-san-desu
Copy link
Contributor

cf. #1600

#1601 の対応と同様に、c-search 実行時もfixie アドレスを使用する様に更新しました🛠

各イベント管理サービスの group_id の取得方法 - how_to_add_dojo.md

  1. connpass のイベントページをブラウザで表示します (Ex. https://coderdojo-tobe.connpass.com/)
  2. イベントのページを表示します (どのイベントでもOK)
  3. イベントページの URL をコピーします
  4. 以下のコマンドで上記のコピーした URL を指定すると group_id (Series ID) が得えられます
$ bin/c-search https://coderdojo-tobe.connpass.com/event/89808/
  => 5072

Copy link
Member

@nanophate nanophate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます!気になる部分があったのでコメントしました。 🙇

Copy link
Contributor

@Yuppymam Yuppymam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます🙏(こちらの対応すっかり見落としていました💦)
1点コメントしましたのでご確認をお願いします🙇‍♀️

Comment on lines +2 to +9
ENV_FILE=".env"

if [ ! -f "$ENV_FILE" ]; then
echo "$ENV_FILE が見つかりません"
exit 1
fi

source "$ENV_FILE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXIE_URLが設定されているかどうかを確認したほうが良いかもですね😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuppymam
f9000b5 で対応しました!

Copy link
Contributor

@Yuppymam Yuppymam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございました!🙇‍♀️

@rakuda-san-desu
Copy link
Contributor Author

レビューありがとうございました!
マージします🛠

@rakuda-san-desu rakuda-san-desu merged commit aace2a1 into main Jun 10, 2024
2 checks passed
@rakuda-san-desu rakuda-san-desu deleted the update_c-search branch June 10, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants